refactor(fc2c-i): sweep blueprints + ml tasks onto shared get_session (covers tasks/ml.py, a survey gap)

backend/app/api/suggestions.py

@@ -2,28 +2,16 @@
 
 from quart import Blueprint, jsonify, request
 
-from ..extensions import make_engine, make_session_factory
+from ..extensions import get_session
 from ..services.ml.allowlist import AllowlistService
 from ..services.ml.suggestions import SuggestionService
 
 suggestions_bp = Blueprint("suggestions", __name__, url_prefix="/api")
 
-_engine = None
-_Session = None
-
-
-def _session_factory():
-    global _engine, _Session
-    if _engine is None:
-        _engine = make_engine()
-        _Session = make_session_factory(_engine)
-    return _Session
-
 
 @suggestions_bp.route("/images/<int:image_id>/suggestions", methods=["GET"])
 async def get_suggestions(image_id: int):
-    Session = _session_factory()
-    async with Session() as session:
+    async with get_session() as session:
         sl = await SuggestionService(session).for_image(image_id)
     return jsonify(
         {
@@ -53,8 +41,7 @@ async def accept_suggestion(image_id: int):
     if not body or "tag_id" not in body:
         return jsonify({"error": "tag_id required"}), 400
     tag_id = body["tag_id"]
-    Session = _session_factory()
-    async with Session() as session:
+    async with get_session() as session:
         newly_added = await AllowlistService(session).accept(image_id, tag_id)
         await session.commit()
     if newly_added:
@@ -72,8 +59,7 @@ async def alias_suggestion(image_id: int):
     required = {"alias_string", "alias_category", "canonical_tag_id"}
     if not body or not required.issubset(body):
         return jsonify({"error": f"required: {sorted(required)}"}), 400
-    Session = _session_factory()
-    async with Session() as session:
+    async with get_session() as session:
         newly_added = await AllowlistService(session).add_alias_and_accept(
             image_id,
             body["alias_string"],
@@ -95,8 +81,7 @@ async def dismiss_suggestion(image_id: int):
     body = await request.get_json()
     if not body or "tag_id" not in body:
         return jsonify({"error": "tag_id required"}), 400
-    Session = _session_factory()
-    async with Session() as session:
+    async with get_session() as session:
         await AllowlistService(session).dismiss(image_id, body["tag_id"])
         await session.commit()
     return "", 204