fix: supervisorctl could not reach supervisord inside the container (4295)

The smoke's own diagnostic line printed this for a whole run and passed, because it was behind `|| true`: Error: .ini file does not include supervisorctl section supervisord was fine. `supervisorctl` simply could not talk to it — the generated config had no `[unix_http_server]`, `[supervisorctl]` or `[rpcinterface:supervisor]`. That is the first tool anyone reaches for when a lane misbehaves in the consolidated container. `docker exec <c> supervisorctl status` to see which processes are actually up; `restart ml` to bounce one without taking the whole application down with it. Consolidation took `docker ps` away as the way to see the lanes, and this is what replaces it — so shipping without it would have left an operator with one container, five processes inside it, and no way to ask about any of them. They are about to run this in production. The test asserts the three sections AGREE on one socket path rather than merely existing: a serverurl pointing where nothing listens fails in exactly the same way and reads as configured. The smoke's line loses its `|| true`. A diagnostic allowed to fail silently is one that stops being true without telling anyone — which is precisely what happened here. It still printed the evidence that something was wrong while nothing depended on it, which is the argument for printing it at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
2026-09-23 09:09:11 -04:00
parent efde3b188f
commit b09ee87255
3 changed files with 81 additions and 1 deletions
@@ -231,3 +231,33 @@ def test_every_lane_gets_its_own_celery_node_name():
    )
    for lane, node in names.items():
        assert node == lane, f"{lane} announces itself as {node!r}"
+
+
+def test_supervisorctl_can_reach_supervisord():
+    """Consolidation took away `docker ps` as the way to see the lanes, and
+    this is what replaces it.
+
+    Without the three control-socket sections supervisord runs perfectly and
+    `supervisorctl` cannot talk to it at all:
+
+        Error: .ini file does not include supervisorctl section
+
+    That is the first thing anyone reaches for when a lane misbehaves inside
+    the one container — `supervisorctl status` to see which processes are up,
+    `restart ml` to bounce one without taking the application down. Shipping
+    without it leaves an operator with five processes and no way to ask about
+    any of them.
+
+    Asserted as the three sections AGREEING on one socket path, not merely as
+    three sections existing: a serverurl pointing somewhere the server does
+    not listen fails exactly the same way, and reads as configured.
+    """
+    cp = _parse()
+    for section in ("unix_http_server", "supervisorctl", "rpcinterface:supervisor"):
+        assert cp.has_section(section), f"no [{section}] — supervisorctl is blind"
+
+    listening = cp.get("unix_http_server", "file")
+    talking = cp.get("supervisorctl", "serverurl")
+    assert talking == f"unix://{listening}", (
+        f"supervisorctl talks to {talking}, supervisord listens on {listening}"
+    )