fix: supervisorctl could not reach supervisord inside the container (4295)

The smoke's own diagnostic line printed this for a whole run and passed, because it was behind `|| true`: Error: .ini file does not include supervisorctl section supervisord was fine. `supervisorctl` simply could not talk to it — the generated config had no `[unix_http_server]`, `[supervisorctl]` or `[rpcinterface:supervisor]`. That is the first tool anyone reaches for when a lane misbehaves in the consolidated container. `docker exec <c> supervisorctl status` to see which processes are actually up; `restart ml` to bounce one without taking the whole application down with it. Consolidation took `docker ps` away as the way to see the lanes, and this is what replaces it — so shipping without it would have left an operator with one container, five processes inside it, and no way to ask about any of them. They are about to run this in production. The test asserts the three sections AGREE on one socket path rather than merely existing: a serverurl pointing where nothing listens fails in exactly the same way and reads as configured. The smoke's line loses its `|| true`. A diagnostic allowed to fail silently is one that stops being true without telling anyone — which is precisely what happened here. It still printed the evidence that something was wrong while nothing depended on it, which is the argument for printing it at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR
2026-09-23 09:09:11 -04:00
parent efde3b188f
commit b09ee87255
3 changed files with 81 additions and 1 deletions
@@ -1555,7 +1555,15 @@ jobs:
          echo "smoke: every lane answered"
          # Say WHICH processes supervisord is running, so a lane that is
          # merely restart-looping is visible rather than inferred.
-          docker exec "$CID_ALL" supervisorctl -c "${SUPERVISOR_CONF:-/tmp/supervisord.conf}" status || true
+          #
+          # NOT `|| true` any more. Behind that, this printed
+          # "Error: .ini file does not include supervisorctl section" for a
+          # whole run and passed — supervisord was fine and supervisorctl
+          # could not reach it, which is the tool an operator debugging a lane
+          # inside the one container reaches for first. A diagnostic allowed
+          # to fail silently is a diagnostic that stops being true without
+          # telling anyone.
+          docker exec "$CID_ALL" supervisorctl -c "${SUPERVISOR_CONF:-/tmp/supervisord.conf}" status

          echo "smoke: all checks passed against $CANDIDATE, with egress blocked"