bvandeusen/FabledCurator
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 12 Wiki Activity

feat: PatreonClient.iter_memberships — the roster seam (milestone 387 step C2)
CI / lint (push) Successful in 3s
Details
CI / extension-version (push) Successful in 3s
Details
Build images / sign-extension (push) Successful in 5s
Details
Build images / build-agent (push) Successful in 7s
Details
CI / frontend-build (push) Successful in 24s
Details
CI / backend-lint-and-test (push) Successful in 58s
Details
Build images / build-web (push) Successful in 1m16s
Details
Build images / smoke-web (push) Skipped
Details
CI / integration (push) Successful in 2m25s
Details
Build images / build-ml (push) Successful in 2m45s
Details
Build images / promote (push) Skipped
Details

Browse Source 
Built on C0's real capture (Scribe note #3886), not on API docs — gallery-dl
has no membership extractor and Patreon's public v2 API is the CREATOR surface
behind OAuth, so the rule-130 reference had to be a characterized response.

**The request is deliberately minimal, and that is a privacy decision.** The
browser's own include set pulls `latest_pledge.card`, and those card resources
come back carrying the ACCOUNT HOLDER'S EMAIL in `merchant_name`; `address` is
in there too. Copying the query string wholesale is the obvious move and would
have FC fetching payment PII it has no use for and can only mishandle. We ask
for `include=campaign,reward` and nothing else, and a test asserts on the
params actually sent so nobody widens it back.

**We do not send `filter[membership_type]`.** The browser sends the six buckets
its settings page displays, which excludes lapsed memberships — and a
DISAPPEARANCE is precisely the signal the roster exists to read. Filtering here
would manufacture the event C4 acts on.

Two corrections the capture forced, both now in code:

* **The filter vocabulary is not the status vocabulary.** I had read the six
  filter words off a screenshot and was about to write them into
  MEMBERSHIP_STATUS as the enum. The body shows `patron_status` carrying
  `former_patron` — absent from that filter — on a row the filter selected as
  `free_member`. So the map is taught exactly the two OBSERVED values, and
  `declined_patron` stays out despite looking obviously right: believing the
  filter is the mistake that was just caught.
* **Free membership is a boolean, not a status.** `has_paid_access` gains an
  `is_free_member` axis, because `active_patron` alone would report a free
  follower as a paying patron and C4 would never offer to clean it up. Honest
  limit, stated in the docstring: the capture has no ACTIVE free member, so it
  shows the separation is possible, not that it occurs.

C1's tripwire test did its job — it was written to fail the moment anyone
populated the status map, and updating it here IS the confirmation step, done
with the capture rather than ahead of it.

`_fetch`'s retry/backoff/auth-vs-drift/Retry-After logic is extracted to a
shared `_request` so the roster rides the same path rather than growing a
second copy — two copies would drift, and the half that drifted would be the
one that only runs daily. Every error message and log line renders
byte-identically for the posts path, so the existing tests pin the refactor.

Pagination is driven by `page[offset]` against `meta.pagination.total`, never
by `links`: the response's own `links.first` is built WITHOUT the `/api/`
prefix the request uses, so following it would hit the web page. An empty page
is terminal regardless of what the total claims, so a server reporting more
rows than it hands over cannot spin the walk forever.

Drift is stricter here than on the posts path, on purpose: a missing
`meta.pagination.total` raises rather than returning a short list, because a
truncated roster reads downstream as "you cancelled those" — the worst wrong
answer this feature can give.

`current_user_id()` is marked INFERRED, not characterized: C0 captured
/api/members, not /api/current_user, so it relies only on the JSON:API envelope
this API demonstrably uses elsewhere, and raises drift rather than returning
something plausible if that is wrong.

The fixture is derived from the real capture with every piece of account data
replaced (the raw capture stays gitignored). Six members, each earning its
place: a former patron with a null pledge, an active patron with no tier, an
annual cadence, a previous_pledge whose included resource has no
`relationships` key at all, and a reward priced in CAD beside a USD charge —
the trap that makes reading `reward.amount_cents` report a number the operator
was never charged. A leak check caught a free-membership-subscription id and
six real campaign launch timestamps before any of it was staged.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LNXXULQDjVZmbuNa2G9mD9
This commit is contained in:
bvandeusen
2026-09-10 22:26:01 -04:00
co-authored by Claude Opus 5
parent 533a1ce674
commit afcde8e457
5 changed files with 1346 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/fixtures/patreon_members_page1.json
Vendored
+723
View File
@@ -0,0 +1,723 @@
{
"data": [
{
"id": "00000000-0000-4000-8000-000000000000",
"type": "member",
"attributes": {
"access_expires_at": "2026-01-02T00:00:00.000+00:00",
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": true,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "former_patron",
"pledge_amount_cents": null,
"pledge_cadence": 1
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000001",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700001",
"type": "pledge"
}
},
"previous_pledge": {
"data": null
},
"reward": {
"data": {
"id": "90001",
"type": "reward"
}
}
}
},
{
"id": "00000000-0000-4000-8000-000000000001",
"type": "member",
"attributes": {
"access_expires_at": null,
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": false,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "active_patron",
"pledge_amount_cents": 1000,
"pledge_cadence": 1
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000002",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700002",
"type": "pledge"
}
},
"previous_pledge": {
"data": null
},
"reward": {
"data": null
}
}
},
{
"id": "00000000-0000-4000-8000-000000000002",
"type": "member",
"attributes": {
"access_expires_at": null,
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": false,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "active_patron",
"pledge_amount_cents": 1500,
"pledge_cadence": 12
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000003",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700003",
"type": "pledge"
}
},
"previous_pledge": {
"data": {
"id": "700004",
"type": "pledge"
}
},
"reward": {
"data": {
"id": "90002",
"type": "reward"
}
}
}
},
{
"id": "00000000-0000-4000-8000-000000000003",
"type": "member",
"attributes": {
"access_expires_at": null,
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": false,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "active_patron",
"pledge_amount_cents": 2000,
"pledge_cadence": 1
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000004",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700005",
"type": "pledge"
}
},
"previous_pledge": {
"data": {
"id": "700006",
"type": "pledge"
}
},
"reward": {
"data": {
"id": "90003",
"type": "reward"
}
}
}
},
{
"id": "00000000-0000-4000-8000-000000000004",
"type": "member",
"attributes": {
"access_expires_at": null,
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": false,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "active_patron",
"pledge_amount_cents": 2500,
"pledge_cadence": 1
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000005",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700007",
"type": "pledge"
}
},
"previous_pledge": {
"data": null
},
"reward": {
"data": {
"id": "90004",
"type": "reward"
}
}
}
},
{
"id": "00000000-0000-4000-8000-000000000005",
"type": "member",
"attributes": {
"access_expires_at": null,
"currency": "USD",
"gift_paid_conversion_reward_cadence": null,
"grant_type": null,
"is_free_member": false,
"is_gifted": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00",
"patron_status": "active_patron",
"pledge_amount_cents": 3000,
"pledge_cadence": 1
},
"relationships": {
"address": {
"data": null
},
"billing_subscription_scheduled_event": {
"data": null
},
"campaign": {
"data": {
"id": "1000006",
"type": "campaign"
}
},
"gift_paid_conversion_payment_method": {
"data": null
},
"latest_pledge": {
"data": {
"id": "700008",
"type": "pledge"
}
},
"previous_pledge": {
"data": null
},
"reward": {
"data": {
"id": "90005",
"type": "reward"
}
}
}
}
],
"included": [
{
"id": "1000001",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": false,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator One",
"owner_id": 5000000,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-one",
"published_at": "2020-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-one",
"url_for_current_user": "https://www.patreon.com/cw/creator-one",
"vanity": "creator-one"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": {
"id": "80000000",
"type": "free-membership-subscription"
}
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "1000002",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": false,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator Two",
"owner_id": 5000001,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-two",
"published_at": "2021-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-two",
"url_for_current_user": "https://www.patreon.com/c/creator-two",
"vanity": "creator-two"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": null
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "1000003",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": true,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator Three",
"owner_id": 5000002,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-three",
"published_at": "2022-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-three",
"url_for_current_user": "https://www.patreon.com/c/creator-three",
"vanity": "creator-three"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": null
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "1000004",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": true,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator Four",
"owner_id": 5000003,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-four",
"published_at": "2023-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-four",
"url_for_current_user": "https://www.patreon.com/cw/creator-four",
"vanity": "creator-four"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": null
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "1000005",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": true,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator Five",
"owner_id": 5000004,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-five",
"published_at": "2024-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-five",
"url_for_current_user": "https://www.patreon.com/c/creator-five",
"vanity": "creator-five"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": null
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "1000006",
"type": "campaign",
"attributes": {
"annual_pledging_enabled": false,
"avatar_photo_url": "https://example.invalid/avatar.jpg",
"cover_photo_url": "https://example.invalid/cover.jpg",
"is_active": true,
"is_monthly": true,
"is_non_profit": false,
"name": "Creator Six",
"owner_id": 5000005,
"pay_per_name": "month",
"pledge_url": "https://www.patreon.com/checkout/creator-six",
"published_at": "2025-01-01T00:00:00.000+00:00",
"url": "https://www.patreon.com/creator-six",
"url_for_current_user": "https://www.patreon.com/cw/creator-six",
"vanity": "creator-six"
},
"relationships": {
"current_user_free_membership_subscription": {
"data": null
},
"current_user_gift": {
"data": null
},
"rewards": {
"data": [
{
"id": "-1",
"type": "reward"
}
]
}
}
},
{
"id": "90001",
"type": "reward",
"attributes": {
"amount_cents": 0,
"currency": "EUR",
"description": "<p>Tier benefits.</p>",
"image_url": null,
"patron_amount_cents": 100,
"requires_shipping": false,
"title": "Tier A",
"unpublished_at": null
}
},
{
"id": "90002",
"type": "reward",
"attributes": {
"amount_cents": 499,
"currency": "USD",
"description": "<p>Tier benefits.</p>",
"image_url": "https://example.invalid/reward.png",
"patron_amount_cents": 499,
"requires_shipping": false,
"title": "Tier B",
"unpublished_at": null
}
},
{
"id": "90003",
"type": "reward",
"attributes": {
"amount_cents": 400,
"currency": "USD",
"description": "<p>Tier benefits.</p>",
"image_url": "https://example.invalid/reward.png",
"patron_amount_cents": 400,
"requires_shipping": false,
"title": "Tier C",
"unpublished_at": null
}
},
{
"id": "90004",
"type": "reward",
"attributes": {
"amount_cents": 570,
"currency": "CAD",
"description": "<p>Tier benefits.</p>",
"image_url": "https://example.invalid/reward.png",
"patron_amount_cents": 450,
"requires_shipping": false,
"title": "Tier D",
"unpublished_at": null
}
},
{
"id": "90005",
"type": "reward",
"attributes": {
"amount_cents": 1000,
"currency": "USD",
"description": "<p>Tier benefits.</p>",
"image_url": "https://example.invalid/reward.png",
"patron_amount_cents": 1000,
"requires_shipping": false,
"title": "Tier E",
"unpublished_at": null
}
},
{
"id": "700001",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "700002",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "700003",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 12,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "700004",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 12,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
}
},
{
"id": "700005",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "700006",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
}
},
{
"id": "700007",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "700008",
"type": "pledge",
"attributes": {
"amount_cents": 500,
"cadence": 1,
"currency": "USD",
"is_apple_iap_subscription": false,
"is_grandfathered": false,
"next_charge_date": "2026-12-15T00:00:00.000+00:00"
},
"relationships": {}
},
{
"id": "-1",
"type": "reward",
"attributes": {
"amount": 0,
"amount_cents": 0,
"description": "Everyone",
"user_limit": null,
"remaining": 0,
"requires_shipping": false,
"created_at": null,
"url": null,
"patron_currency": "USD"
}
},
{
"id": "00000000-0000-4000-8000-ffffffffffff",
"type": "card",
"attributes": {
"card_type": "PayPal",
"expiration_date": null,
"merchant_name": "billing@example.invalid",
"number": null
}
}
],
"links": {
"first": "https://www.patreon.com/members?page%5Boffset%5D=0"
},
"meta": {
"count": 6,
"sort": "-pledge_relationship_start",
"pagination": {
"total": 6
}
}
}
tests/test_membership_roster.py
+37 -6
View File
@@ -153,15 +153,46 @@ def test_unknown_platform_is_unknown():
assert has_paid_access("a-platform-with-no-mapping", "active") is None
def test_the_status_map_starts_empty_and_that_is_deliberate():
def test_the_status_map_contains_only_characterised_values():
"""Guards project rule 130 at the one place it is easiest to break.
Every entry must come from a characterised response (step C0), never from
API docs or a plausible-looking guess. If this assertion fails, either C0
happened — in which case update this test along with the map, citing the
capture — or somebody guessed, which is the thing the rule exists to stop.
Every entry must come from a characterised response, never from API docs or
a plausible-looking guess. This started life asserting the map was EMPTY;
C0 then captured Patreon's real `/api/members` response (Scribe note #3886)
and this assertion is the confirmation step — updated with the capture, not
ahead of it.
`declined_patron` is absent ON PURPOSE and must stay absent until a capture
shows it in `patron_status`. It appears in the request's
`filter[membership_type]`, and the capture proved that filter is a
different vocabulary from the attribute: a row the filter selected as
`free_member` came back as `former_patron`, a word the filter does not
contain. Adding it because it "obviously" belongs is precisely the guess
this test exists to stop.
"""
assert MEMBERSHIP_STATUS == {}
assert MEMBERSHIP_STATUS == {
"patreon": {"active_patron": True, "former_patron": False},
}
def test_a_free_member_does_not_count_as_paid_access():
"""The second axis. Patreon expresses a free follow as a boolean beside
`patron_status`, so a CURRENT membership can still be one nobody pays for —
and reporting that as paid access would hide it from C4 forever."""
assert has_paid_access("patreon", "active_patron") is True
assert has_paid_access("patreon", "active_patron", is_free_member=True) is False
def test_the_free_flag_cannot_rescue_a_lapsed_membership():
"""False from the status is terminal: not-free does not mean still-paying."""
assert has_paid_access("patreon", "former_patron") is False
assert has_paid_access("patreon", "former_patron", is_free_member=False) is False
def test_an_unknown_status_stays_unknown_whatever_the_free_flag_says():
"""The free flag refines a KNOWN answer; it never manufactures one."""
assert has_paid_access("patreon", "declined_patron") is None
assert has_paid_access("patreon", "declined_patron", is_free_member=True) is None
def test_the_map_is_consulted_once_it_has_entries(monkeypatch):
tests/test_patreon_memberships.py
+287
View File
@@ -0,0 +1,287 @@
"""PatreonClient.iter_memberships — parsing only, no network (#387 C2).
The fixture is derived from a REAL capture of the operator's session (Scribe
note #3886) with every piece of account data replaced. It is small on purpose
and each member in it earns its place by covering something the parser has to
survive: a former patron with a null pledge, an active patron with no tier, an
annual cadence, a previous pledge whose included resource has no
`relationships` key at all, and a reward priced in a currency that is not the
patron's.
`_request` is stubbed rather than mocked at the socket: these tests are about
what the client does with a payload, and the HTTP path is already covered by
test_patreon_client.py.
"""
import json
from pathlib import Path
import pytest
from backend.app.services.patreon_client import (
Membership,
PatreonClient,
PatreonDriftError,
)
_FIXTURE = Path(__file__).parent / "fixtures" / "patreon_members_page1.json"
@pytest.fixture
def payload():
return json.loads(_FIXTURE.read_text())
@pytest.fixture
def client():
return PatreonClient(cookies_path=None)
def _serve(client, *pages):
"""Stub the shared request path to hand back canned pages in order."""
calls = []
def fake(url, params, *, what, scope):
calls.append((url, dict(params), what))
return pages[min(len(calls) - 1, len(pages) - 1)]
client._request = fake
return calls
# --- the request we send ---------------------------------------------------
def test_we_never_ask_for_the_card_or_address(client, payload):
"""THE privacy guard, and the reason it is first.
The browser's own include set pulls `latest_pledge.card`, and those card
resources come back carrying the ACCOUNT HOLDER'S EMAIL in `merchant_name`
(note #3886). Copying the browser's query string wholesale is the obvious
move and would have FC fetching payment PII it has no use for. This asserts
on the params actually sent, so it fails if anyone widens the include set
back toward the browser's.
"""
calls = _serve(client, payload)
list(client.iter_memberships(user_id="1"))
_url, params, _what = calls[0]
include = params["include"]
assert include == "campaign,reward"
for forbidden in ("card", "address", "payment_method", "latest_pledge"):
assert forbidden not in include
assert not any(k.startswith("fields[card") for k in params)
def test_we_do_not_send_the_membership_type_filter(client, payload):
"""The browser filters to the six buckets its settings page shows, which
excludes lapsed memberships. A DISAPPEARANCE is the signal the roster
exists to read, so filtering here would manufacture exactly the event C4
acts on."""
calls = _serve(client, payload)
list(client.iter_memberships(user_id="1"))
assert "filter[membership_type]" not in calls[0][1]
def test_the_user_filter_is_sent_when_given_and_omitted_when_not(client, payload):
calls = _serve(client, payload)
list(client.iter_memberships(user_id="248453"))
assert calls[0][1]["filter[user_id]"] == "248453"
calls2 = _serve(client, payload)
list(client.iter_memberships())
assert "filter[user_id]" not in calls2[0][1]
# --- what we parse out of it ----------------------------------------------
def test_every_member_becomes_a_membership(client, payload):
client._request = lambda *a, **k: payload
rows = list(client.iter_memberships(user_id="1"))
assert len(rows) == len(payload["data"])
assert all(isinstance(r, Membership) for r in rows)
# Campaign identity is the join key to Source; it must always be there.
assert all(r.campaign_id for r in rows)
def test_status_is_the_platforms_own_word_unmapped(client, payload):
client._request = lambda *a, **k: payload
rows = list(client.iter_memberships(user_id="1"))
statuses = {r.status for r in rows}
assert "active_patron" in statuses
assert "former_patron" in statuses
# Nothing normalised, nothing invented.
assert statuses <= {"active_patron", "former_patron"}
def test_a_former_patron_carries_a_null_amount_and_the_free_flag(client, payload):
client._request = lambda *a, **k: payload
former = next(r for r in list(client.iter_memberships(user_id="1"))
if r.status == "former_patron")
assert former.amount_cents is None
assert former.is_free_member is True
def test_an_active_patron_with_no_tier_is_not_an_error(client, payload):
"""`reward.data` is legitimately null. Absence is a fact about the
membership, not a parse failure."""
client._request = lambda *a, **k: payload
rows = list(client.iter_memberships(user_id="1"))
untiered = [r for r in rows if not r.tier_names]
assert untiered, "fixture should contain a member with no reward"
assert all(r.status for r in untiered)
def test_the_amount_comes_from_the_member_not_the_reward(client, payload):
"""The capture has rewards priced in CAD/DKK/EUR sitting on USD pledges.
Reading `reward.amount_cents` would report a number the operator has never
been charged, in a currency they do not pay in."""
client._request = lambda *a, **k: payload
rows = list(client.iter_memberships(user_id="1"))
by_campaign = {r.campaign_id: r for r in rows}
rewards = {r["id"]: r["attributes"] for r in payload["included"]
if r["type"] == "reward"}
for member in payload["data"]:
rel = (member["relationships"].get("reward") or {}).get("data")
if not rel:
continue
reward = rewards[rel["id"]]
if reward.get("currency") in (None, "USD"):
continue
# Skip the null-amount member: `None != 0` would pass without
# demonstrating anything. The case worth pinning is a REAL charge
# sitting beside a reward priced in another currency.
if member["attributes"]["pledge_amount_cents"] is None:
continue
got = by_campaign[member["relationships"]["campaign"]["data"]["id"]]
assert got.amount_cents == member["attributes"]["pledge_amount_cents"]
assert got.amount_cents != reward["amount_cents"]
assert got.currency == member["attributes"]["currency"]
break
else:
pytest.fail("fixture should contain a non-USD reward")
def test_details_carry_the_raw_attributes_but_not_the_whole_page(client, payload):
"""`details` exists so a later question needs no second authenticated
round-trip — but scoped to the member and its campaign, never the raw page,
because that is where the card and address resources live."""
client._request = lambda *a, **k: payload
row = next(iter(client.iter_memberships(user_id="1")))
assert set(row.details) == {"member", "campaign"}
assert "patron_status" in row.details["member"]
assert json.dumps(row.details).count("@") == 0
# --- pagination ------------------------------------------------------------
def test_pagination_walks_offsets_until_the_total_is_reached(client, payload):
half = len(payload["data"]) // 2
page1 = {**payload, "data": payload["data"][:half],
"meta": {"pagination": {"total": len(payload["data"])}}}
page2 = {**payload, "data": payload["data"][half:],
"meta": {"pagination": {"total": len(payload["data"])}}}
calls = []
def fake(url, params, *, what, scope):
calls.append(dict(params))
return page1 if len(calls) == 1 else page2
client._request = fake
rows = list(client.iter_memberships(user_id="1"))
assert len(rows) == len(payload["data"])
assert [c["page[offset]"] for c in calls] == ["0", str(half)]
def test_an_empty_page_stops_the_walk_even_if_the_total_disagrees(client):
"""A server that reports more rows than it hands over must not spin us
forever. The empty page is terminal regardless of the total."""
page = {"data": [], "included": [], "meta": {"pagination": {"total": 999}}}
client._request = lambda *a, **k: page
assert list(client.iter_memberships(user_id="1")) == []
def test_an_empty_roster_is_not_an_error(client):
page = {"data": [], "included": [], "meta": {"pagination": {"total": 0}}}
client._request = lambda *a, **k: page
assert list(client.iter_memberships(user_id="1")) == []
def test_we_never_follow_links_first(client, payload):
"""The response's own `links.first` is built WITHOUT the `/api/` prefix the
request uses, so following it would hit the web page. Pagination is driven
by page[offset] instead — asserted here because the bug it prevents looks
like an auth failure, not a URL mistake."""
assert "/api/" not in payload["links"]["first"]
calls = _serve(client, payload)
list(client.iter_memberships(user_id="1"))
assert all(url.startswith("https://www.patreon.com/api/") for url, _p, _w in calls)
# --- drift -----------------------------------------------------------------
def test_a_missing_total_is_drift_not_an_empty_roster(client, payload):
"""The distinction that matters most here. An empty roster reads to C4 as
'you cancelled everything', so a response we cannot verify as COMPLETE must
raise rather than return a short list."""
broken = {**payload, "meta": {}}
client._request = lambda *a, **k: broken
with pytest.raises(PatreonDriftError, match="pagination"):
list(client.iter_memberships(user_id="1"))
def test_a_missing_data_list_is_drift(client, payload):
client._request = lambda *a, **k: {"meta": {"pagination": {"total": 0}}}
with pytest.raises(PatreonDriftError):
list(client.iter_memberships(user_id="1"))
def test_a_member_with_no_campaign_is_drift(client, payload):
mangled = json.loads(json.dumps(payload))
mangled["data"][0]["relationships"]["campaign"] = {"data": None}
client._request = lambda *a, **k: mangled
with pytest.raises(PatreonDriftError, match="campaign"):
list(client.iter_memberships(user_id="1"))
def test_a_member_with_no_patron_status_is_drift(client, payload):
mangled = json.loads(json.dumps(payload))
del mangled["data"][0]["attributes"]["patron_status"]
client._request = lambda *a, **k: mangled
with pytest.raises(PatreonDriftError, match="patron_status"):
list(client.iter_memberships(user_id="1"))
# --- current_user_id -------------------------------------------------------
def test_current_user_id_reads_the_json_api_envelope(client):
client._request = lambda *a, **k: {"data": {"id": "248453", "type": "user"}}
assert client.current_user_id() == "248453"
def test_current_user_id_raises_drift_rather_than_guessing(client):
"""This endpoint is INFERRED, not characterized (note #3886). If the
inference is wrong it must fail loudly — a confidently wrong user id would
scope the roster to somebody else and return an empty, believable list."""
client._request = lambda *a, **k: {"data": []}
with pytest.raises(PatreonDriftError, match="current_user"):
client.current_user_id()
# --- the seam itself -------------------------------------------------------
def test_the_seam_is_probed_not_required():
"""Milestone 387's whole seam design, and the reason Discord needs no
'unsupported' branch: a client without the method is simply a client the
roster never asks. Mirrors ingest_core's `getattr(client, 'post_is_gated')`.
"""
class ClientWithoutIt:
pass
assert getattr(ClientWithoutIt(), "iter_memberships", None) is None
assert getattr(PatreonClient(cookies_path=None), "iter_memberships", None)