fix(modal): accept-by-known-id keeps the raw suggestion row identity for the drop
CI / lint (push) Successful in 4s
CI / frontend-build (push) Successful in 29s
CI / backend-lint-and-test (push) Successful in 1m6s
CI / integration (push) Successful in 4m31s

Spreading canonical_tag_id onto a raw suggestion changed its _keyOf
identity, so _dropEverywhere missed the actual list row and the panel
kept showing an already-accepted suggestion. Pass the resolved id as an
option instead; pinned with a raw-suggestion spec.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CDgx8bQS5YrGRK76v8HUnM
This commit is contained in:
2026-07-02 22:02:24 -04:00
parent 6d314d662f
commit 581b778528
3 changed files with 35 additions and 11 deletions
+26 -4
View File
@@ -78,13 +78,35 @@ describe('suggestions store: accept with a known tag id', () => {
calls.push({ url, method: init?.method })
return { status: 200, body: { accepted: true, tag_id: 7 } }
})
// TagPanel routes a manual pick that matches a pending suggestion through
// accept, filling canonical_tag_id from the picked hit when the
// suggestion is raw — no /api/tags create must fire in that case.
await s.accept({ ...s.byCategory.character[0], canonical_tag_id: 7 })
await s.accept(s.byCategory.character[0], { tagId: 7 })
expect(calls).toHaveLength(1)
expect(calls[0].url).toContain('/api/images/1/suggestions/accept')
expect(s.byCategory.character).toHaveLength(0)
expect(s.allByCategory.character).toHaveLength(0)
})
it('a RAW suggestion accepted with a known tagId skips create AND still drops its row', async () => {
// TagPanel's manual-create path: the tag was just created by
// host.createAndAdd, so accept must not create again — and the drop must
// key off the original raw suggestion object, not the resolved id
// (regression: spreading canonical_tag_id onto the suggestion changed its
// identity key and left the panel row behind).
const s = useSuggestionsStore()
const raw = sugg({
canonical_tag_id: null, display_name: 'Holding Sword',
category: 'general', creates_new_tag: true,
})
await seed(s, { general: [raw] })
const calls = []
stubFetch((url, init) => {
calls.push({ url, body: init?.body })
return { status: 200, body: { accepted: true, tag_id: 42 } }
})
await s.accept(s.byCategory.general[0], { tagId: 42 })
expect(calls).toHaveLength(1)
expect(calls[0].url).toContain('/api/images/1/suggestions/accept')
expect(JSON.parse(calls[0].body)).toEqual({ tag_id: 42 })
expect(s.byCategory.general).toHaveLength(0)
expect(s.allByCategory.general).toHaveLength(0)
})
})