feat: the artist picker on Patreon and SubscribeStar too — and the Patreon name is canon (milestone 429)

Operator: "yes add the artist picker to patreon and subscribestar too. but
generally we treat the patreon name as the canon"

- Every add now goes through the panel. On Patreon/SubscribeStar it opens
  on the creator's display name (read only when the panel opens:
  probe?names=1), searches FC's artists with it, and auto-picks a match.
  An untouched URL handle sends no name, so the server still resolves it.
- Patreon is canon: joining a Patreon source to an artist known by another
  name offers "Rename “x” to the Patreon name “X”", ticked by default.
  quick-add's use_platform_name renames server-side from the name it reads
  itself; name only, the slug never moves (#130); never to a URL handle when
  the name can't be read; ignored on SubscribeStar and Discord.
- _platform_display_name returns None rather than the handle, bounded by the
  same 6s lookup budget as Discord's names.
- panelDefaults / addRequest / renameOffer replace the Discord-only helpers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVjrnpQjRgHdvq95rASoiR

extension/test/chip.spec.js

@@ -1,11 +1,12 @@
 import { describe, it, expect } from 'vitest'
 import { loadLib } from './helpers/loadLib.js'
 
-const { chipState, chipLabel, discordPanelDefaults, discordAddRequest } = loadLib('chip.js', [
+const { chipState, chipLabel, panelDefaults, addRequest, renameOffer } = loadLib('chip.js', [
   'chipState',
   'chipLabel',
-  'discordPanelDefaults',
-  'discordAddRequest'
+  'panelDefaults',
+  'addRequest',
+  'renameOffer'
 ])
 
 const discord = (extra = {}) => ({
@@ -63,47 +64,47 @@ describe('chip state and label', () => {
   })
 })
 
-describe('Discord Add panel', () => {
+describe('Add panel on Discord', () => {
   it('opens on the channel with the suggested artist preselected', () => {
-    const d = discordPanelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
+    const d = panelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
     expect(d.scope).toBe('channel')
     expect(d.artist).toEqual({ id: 7, name: 'Tamada' })
     expect(d.artistName).toBe('Tamada')
   })
 
   it('proposes a new artist named after the server when nothing is suggested', () => {
-    const d = discordPanelDefaults(discord({ state: 'new' }))
+    const d = panelDefaults(discord({ state: 'new' }))
     expect(d.artist).toBe(null)
     expect(d.artistName).toBe('Studio')
   })
 
   it('sends a picked artist by id', () => {
-    const choice = discordPanelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
-    expect(discordAddRequest(choice)).toEqual({
+    const choice = panelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
+    expect(addRequest(choice)).toEqual({
       url: 'https://discord.com/channels/111/222',
       artistId: 7
     })
   })
 
   it('sends a typed name once the picked artist has been edited away', () => {
-    const choice = discordPanelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
+    const choice = panelDefaults(discord({ state: 'artist_match', artist: { id: 7, name: 'Tamada' } }))
     choice.artistName = 'Tamada Alt'
-    expect(discordAddRequest(choice)).toEqual({
+    expect(addRequest(choice)).toEqual({
       url: 'https://discord.com/channels/111/222',
       artistName: 'Tamada Alt'
     })
   })
 
   it('adds the whole server when the operator picks it', () => {
-    const choice = discordPanelDefaults(discord({ state: 'new' }))
+    const choice = panelDefaults(discord({ state: 'new' }))
     choice.scope = 'server'
-    expect(discordAddRequest(choice).url).toBe('https://discord.com/channels/111')
+    expect(addRequest(choice).url).toBe('https://discord.com/channels/111')
   })
 
   it('has nothing to send without an artist', () => {
-    const choice = discordPanelDefaults(discord({ state: 'new' }))
+    const choice = panelDefaults(discord({ state: 'new' }))
     choice.artistName = '   '
-    expect(discordAddRequest(choice)).toBe(null)
+    expect(addRequest(choice)).toBe(null)
   })
 })
 
@@ -141,3 +142,59 @@ describe('artist matching for the Add panel', () => {
     expect(inlineCompletion('', results)).toBe(null)
   })
 })
+
+describe('Add panel on Patreon and SubscribeStar', () => {
+  const PAGE = 'https://www.patreon.com/cw/tamadaheijun'
+  const patreon = (extra = {}) => ({ platform: 'patreon', slug: 'tamadaheijun', ...extra })
+
+  it('opens on the Patreon display name as a new artist', () => {
+    const c = panelDefaults(patreon({ state: 'new', display_name: 'Tamada Heijun' }), PAGE)
+    expect(c.scope).toBe('page')
+    expect(c.artistName).toBe('Tamada Heijun')
+    expect(addRequest(c)).toEqual({ url: PAGE, artistName: 'Tamada Heijun' })
+  })
+
+  it('leaves an untouched URL handle to the server to resolve', () => {
+    const c = panelDefaults(patreon({ state: 'new' }), PAGE)
+    expect(c.artistName).toBe('tamadaheijun')
+    expect(addRequest(c)).toEqual({ url: PAGE })
+    c.artistName = 'Someone Else'
+    expect(addRequest(c)).toEqual({ url: PAGE, artistName: 'Someone Else' })
+  })
+
+  it('offers the Patreon name when joining an artist known by another name', () => {
+    const c = panelDefaults(patreon({ state: 'new', display_name: 'Tamada Heijun' }), PAGE)
+    c.artist = { id: 4, name: 'tamada' }
+    c.artistName = 'tamada'
+    expect(renameOffer(c)).toEqual({ from: 'tamada', to: 'Tamada Heijun' })
+    expect(addRequest(c)).toEqual({ url: PAGE, artistId: 4, usePlatformName: true })
+    c.adoptPlatformName = false
+    expect(addRequest(c)).toEqual({ url: PAGE, artistId: 4 })
+  })
+
+  it('offers no rename when the names agree or the name was not read', () => {
+    const same = panelDefaults(patreon({ state: 'new', display_name: 'Tamada Heijun' }), PAGE)
+    same.artist = { id: 4, name: 'Tamada Heijun' }
+    expect(renameOffer(same)).toBe(null)
+    const unread = panelDefaults(patreon({ state: 'new' }), PAGE)
+    unread.artist = { id: 4, name: 'tamada' }
+    expect(renameOffer(unread)).toBe(null)
+  })
+
+  it('never renames from SubscribeStar or Discord — Patreon is the canon', () => {
+    const ss = panelDefaults(
+      { platform: 'subscribestar', slug: 'tamada', state: 'new', display_name: 'SS Tamada' },
+      'https://subscribestar.adult/tamada'
+    )
+    ss.artist = { id: 4, name: 'Tamada Heijun' }
+    ss.artistName = 'Tamada Heijun'
+    expect(renameOffer(ss)).toBe(null)
+    expect(addRequest(ss)).toEqual({ url: 'https://subscribestar.adult/tamada', artistId: 4 })
+  })
+
+  it('preselects the artist the URL already names', () => {
+    const c = panelDefaults(patreon({ state: 'artist_match', artist: { id: 9, name: 'Tamada' } }), PAGE)
+    expect(c.artist).toEqual({ id: 9, name: 'Tamada' })
+    expect(c.artistName).toBe('Tamada')
+  })
+})