This repository has been archived on 2026-06-02. You can view files and clone it. You cannot open issues or pull requests or push a commit.
Files
FabledApp/lib/providers/chat_provider.dart
T
bvandeusen 75b7d6d0fe feat(chat): stall watchdog, pull-to-refresh, and unfreeze on refresh
Mobile chat occasionally froze with the input disabled and nothing
progressing — the underlying cause is SSE sockets dropping silently on
mobile network handoffs / proxy idle timeouts. Dio never observes the
close, so the send loop's `await for` hangs indefinitely with
isStreaming=true.

Three changes:
- Wrap the SSE stream in a StreamIterator with a 45s per-event timeout
  as a stall watchdog. On timeout, break out and let the polling pass
  reconcile state from the server.
- Add pull-to-refresh on the chat message list and an AppBar refresh
  button with inline spinner feedback. Works on both empty and
  populated states.
- MessagesNotifier.refresh() now also clears isStreaming /
  streamingStatus when the server reports the latest assistant message
  as complete — so a stuck UI unfreezes the moment the user pulls down
  or taps refresh, even if the original SSE loop is still hanging.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-13 18:13:46 -04:00

245 lines
8.9 KiB
Dart

import 'dart:async';
import 'package:flutter_riverpod/flutter_riverpod.dart';
import '../data/models/conversation.dart';
import '../data/models/message.dart';
import '../data/repositories/chat_repository.dart';
import 'api_client_provider.dart';
// Separate NotifierProvider.family so UI re-builds immediately when streaming starts/stops.
final isStreamingProvider =
NotifierProvider.family<_IsStreamingNotifier, bool, int>(
(convId) => _IsStreamingNotifier(convId),
);
class _IsStreamingNotifier extends Notifier<bool> {
// ignore: avoid_unused_constructor_parameters
_IsStreamingNotifier(int convId);
@override
bool build() => false;
}
// Tracks the current tool status text during generation (empty = no status).
final streamingStatusProvider =
NotifierProvider.family<_StreamingStatusNotifier, String, int>(
(convId) => _StreamingStatusNotifier(convId),
);
class _StreamingStatusNotifier extends Notifier<String> {
// ignore: avoid_unused_constructor_parameters
_StreamingStatusNotifier(int convId);
@override
String build() => '';
}
final conversationsProvider =
AsyncNotifierProvider<ConversationsNotifier, List<Conversation>>(
ConversationsNotifier.new);
class ConversationsNotifier extends AsyncNotifier<List<Conversation>> {
@override
Future<List<Conversation>> build() async {
return ref.watch(chatRepositoryProvider).getConversations();
}
Future<Conversation> create(String title) async {
final conv =
await ref.read(chatRepositoryProvider).createConversation(title);
state = AsyncData([conv, ...state.value ?? []]);
return conv;
}
Future<void> delete(int id) async {
await ref.read(chatRepositoryProvider).deleteConversation(id);
state = AsyncData([
for (final c in state.value ?? [])
if (c.id != id) c,
]);
}
/// Re-fetch conversations without clearing the current list (no flicker).
Future<void> refresh() async {
final fresh = await ref.read(chatRepositoryProvider).getConversations();
state = AsyncData(fresh);
}
// Called after a message is sent to patch the server-generated title
// in-place without triggering a full reload or loading state.
void patchConversation(Conversation updated) {
final list = state.value;
if (list == null) return;
state = AsyncData([
for (final c in list)
if (c.id == updated.id) updated else c,
]);
}
}
final messagesProvider =
AsyncNotifierProvider.family<MessagesNotifier, List<Message>, int>(
(convId) => MessagesNotifier(convId),
);
class MessagesNotifier extends AsyncNotifier<List<Message>> {
final int _convId;
MessagesNotifier(this._convId);
@override
Future<List<Message>> build() async {
final (_, messages) =
await ref.watch(chatRepositoryProvider).getMessages(_convId);
return messages;
}
/// Re-fetch messages without clearing the current list (no flicker).
///
/// Also unfreezes the UI if streaming state got stuck true — this happens
/// when an SSE connection dies silently (mobile network handoff, app
/// backgrounded mid-stream, reverse proxy dropping idle sockets) and the
/// send loop never observes a close. If the server-side message is already
/// done, we clear `isStreamingProvider` so the input unlocks.
Future<void> refresh() async {
final (_, messages) =
await ref.read(chatRepositoryProvider).getMessages(_convId);
state = AsyncData(messages);
Message? lastAssistant;
for (var i = messages.length - 1; i >= 0; i--) {
if (messages[i].role == MessageRole.assistant) {
lastAssistant = messages[i];
break;
}
}
if (lastAssistant != null && lastAssistant.status != 'generating') {
ref.read(isStreamingProvider(_convId).notifier).state = false;
ref.read(streamingStatusProvider(_convId).notifier).state = '';
}
}
Future<void> sendMessage(String content) async {
final convId = _convId;
final repo = ref.read(chatRepositoryProvider);
final previousMessages = state.value ?? [];
// Optimistic UI: show the user message + assistant placeholder immediately.
final userMsg = Message(
conversationId: convId,
role: MessageRole.user,
content: content,
);
final placeholder = Message(
conversationId: convId,
role: MessageRole.assistant,
content: '',
status: 'generating',
);
state = AsyncData([...previousMessages, userMsg, placeholder]);
ref.read(isStreamingProvider(convId).notifier).state = true;
try {
// ── Step 1: POST the message. If this fails the server never got it. ──
await repo.sendMessage(convId, content);
} catch (e) {
state = AsyncData(previousMessages);
ref.read(isStreamingProvider(convId).notifier).state = false;
rethrow;
}
// ── Step 2: Stream the response (best effort — silent on failure). ──
//
// We use a StreamIterator with a per-event timeout as a stall watchdog.
// Mobile networks occasionally drop SSE sockets silently: the TCP
// connection is half-closed, Dio never sees the close, and `await for`
// hangs forever with `isStreaming=true`, freezing the input. If no
// event arrives within the watchdog window we bail out and let the
// polling pass below reconcile state from the server.
const stallTimeout = Duration(seconds: 45);
bool streamedContent = false;
final iter = StreamIterator(repo.streamGeneration(convId));
try {
while (await iter.moveNext().timeout(stallTimeout)) {
final event = iter.current;
if (event is ChatTextChunk) {
streamedContent = true;
ref.read(streamingStatusProvider(convId).notifier).state = '';
final msgs = state.requireValue;
if (msgs.isEmpty) continue;
final updated =
msgs.last.copyWith(content: msgs.last.content + event.text);
state = AsyncData([...msgs.sublist(0, msgs.length - 1), updated]);
} else if (event is ChatStatusUpdate) {
ref.read(streamingStatusProvider(convId).notifier).state =
event.status;
} else if (event is ChatToolCall) {
// Append the tool call to the in-flight assistant message so the
// chip appears live. The reload pass at the end of this function
// will overwrite with the persisted version, which carries the
// same shape — no de-dup needed.
final msgs = state.requireValue;
if (msgs.isEmpty) continue;
final last = msgs.last;
if (last.role != MessageRole.assistant) continue;
final nextCalls = [...?last.toolCalls, event.toolCall];
final updated = last.copyWith(toolCalls: nextCalls);
state = AsyncData([...msgs.sublist(0, msgs.length - 1), updated]);
}
}
} on TimeoutException {
// Stall watchdog — no SSE event for stallTimeout. Fall through to
// polling so the UI eventually unfreezes even if the socket is dead.
} catch (_) {
// SSE failed — fall through to the polling reload below.
} finally {
await iter.cancel();
}
// ── Step 3: Poll the API until we have a completed assistant response.
//
// We always retry up to 20 times regardless of whether SSE streamed
// content. SSE ending does NOT mean the server has finished writing to
// the DB — there can be a brief gap between the stream closing and the
// row being marked complete.
//
// To avoid clobbering SSE-streamed text with a stale empty DB row, we
// only replace state when the polled data is complete OR has content.
try {
for (var attempt = 0; attempt < 20; attempt++) {
if (attempt > 0) await Future.delayed(const Duration(seconds: 2));
final (conv, fresh) = await repo.getMessages(convId);
ref.read(conversationsProvider.notifier).patchConversation(conv);
final done = fresh.any(
(m) => m.role == MessageRole.assistant && m.status != 'generating',
);
final polledHasContent = fresh.any(
(m) => m.role == MessageRole.assistant && m.content.isNotEmpty,
);
// Update UI state when:
// • SSE never delivered anything (polling is the only data source), or
// • the polled response is complete or has content to show.
if (!streamedContent || done || polledHasContent) {
state = AsyncData(fresh);
}
if (done) break;
}
} catch (_) {
// Polling failed entirely — clear the generating placeholder so the UI
// doesn't spin forever.
final msgs = state.value;
if (msgs != null && msgs.isNotEmpty && msgs.last.status == 'generating') {
state = AsyncData([
...msgs.sublist(0, msgs.length - 1),
msgs.last.copyWith(status: 'complete'),
]);
}
} finally {
ref.read(isStreamingProvider(convId).notifier).state = false;
ref.read(streamingStatusProvider(convId).notifier).state = '';
}
}
}